Skip to content

Add CloudDevice service class#1709

Merged
gcatanese merged 4 commits into
mainfrom
add-cloud-device-service
Jun 29, 2026
Merged

Add CloudDevice service class#1709
gcatanese merged 4 commits into
mainfrom
add-cloud-device-service

Conversation

@gcatanese

@gcatanese gcatanese commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Add CloudDeviceApi service class to support the Cloud Device API endpoints:

  • /merchants/{merchantAccount}/devices/{deviceId}/sync
  • /merchants/{merchantAccount}/devices/{deviceId}/async
  • /merchants/{merchantAccount}/connectedDevices
  • /merchants/{merchantAccount}/devices/{deviceId}/status

Added supporting models (which are not part of the OpenAPI spec), unit tests and mock data.

@gcatanese gcatanese requested a review from a team as a code owner June 24, 2026 09:13
@gcatanese gcatanese added the Feature New feature or request label Jun 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the CloudDeviceAPI service to support synchronous and asynchronous payment requests, retrieving connected devices, and checking device status, complete with unit tests and mock data. Feedback on the implementation highlights a potential runtime crash and type unsafety in the async method when parsing responses, as well as unintended side effects caused by mutating the requestOptions parameter directly in getConnectedDevices.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/services/clouddevice/cloudDeviceApi.ts
Comment thread src/services/clouddevice/cloudDeviceApi.ts

@andrej-gajduk-adyen andrej-gajduk-adyen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcatanese gcatanese added this pull request to the merge queue Jun 29, 2026
Merged via the queue into main with commit b7fb7d6 Jun 29, 2026
4 checks passed
@gcatanese gcatanese deleted the add-cloud-device-service branch June 29, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants